three QtFred fixes - #7780
Open
Goober5000 wants to merge 3 commits into
Open
three QtFred fixes#7780Goober5000 wants to merge 3 commits into
Goober5000 wants to merge 3 commits into
Conversation
Only emit rootNodeFormulaChanged when the wrapped node is a formula root. Inserting above a nested expression previously reported a child as an event, goal, or cutscene root, causing assertions and out-of-bounds accesses in the receiving dialog model. Co-Authored-By: OpenAI Codex
Pass the tree model to the cue update handlers and serialize a separate expression for each eligible ship. Sharing one formula across selected ships caused double frees on subsequent edits and left other ships referencing freed nodes when only one ship was changed. This also avoids allocating unused expressions when cue updates are disabled or no selected ships are eligible. Co-Authored-By: OpenAI Codex
Update native Qt editability alongside the shared model flags so variable and container references cannot be edited as plain text. Restore inline editing when a reference is replaced with ordinary data, and preserve item flags when moving or copying branches. Reject edit requests for protected items before setting the editing state, preventing later programmatic changes from being treated as user edits. Co-Authored-By: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only emit rootNodeFormulaChanged when the wrapped node is a formula
root. Inserting above a nested expression previously reported a child
as an event, goal, or cutscene root, causing assertions and out-of-bounds
accesses in the receiving dialog model.
Pass the tree model to the cue update handlers and serialize a separate
expression for each eligible ship. Sharing one formula across selected
ships caused double frees on subsequent edits and left other ships
referencing freed nodes when only one ship was changed.
This also avoids allocating unused expressions when cue updates are
disabled or no selected ships are eligible.
Update native Qt editability alongside the shared model flags so
variable and container references cannot be edited as plain text.
Restore inline editing when a reference is replaced with ordinary data,
and preserve item flags when moving or copying branches.
Reject edit requests for protected items before setting the editing
state, preventing later programmatic changes from being treated as
user edits.