Fix IndexError in search_dates for zh-Hans, zh-Hant, and yue locales - #1377
Open
abhi-0203 wants to merge 1 commit into
Open
Fix IndexError in search_dates for zh-Hans, zh-Hant, and yue locales#1377abhi-0203 wants to merge 1 commit into
abhi-0203 wants to merge 1 commit into
Conversation
… locales - Add i < last_token_index bounds check in translate_search word-joining branch - Add regression unit tests for CJK search_dates Closes scrapinghub#1372
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
IndexError: list index out of rangeinsearch_dates()forzh-Hans,zh-Hant, andyuelocales.Root Cause
In
Locale.translate_search()(dateparser/languages/locale.py), the word-joining branch readoriginal_tokens[i + 1]without checking bounds (i < last_token_index), causing an index overflow on the final token when joined forms matched dictionary entries.Fix
i < last_token_indexbounds check to the word-joining condition.zh-Hans,zh-Hant, andyuelocales intests/test_search.py.Closes #1372