Skip to content

4.x: Continuous requests can leak throttler permits on terminal pre-admission paths #1013

Description

@dkropachev

Problem

ContinuousRequestHandlerBase does not consistently notify the throttler when a request becomes terminal without selecting a node callback.

Two affected paths:

  • An admitted request that exhausts its query plan completes with AllNodesFailedException but never calls signalError, permanently consuming a concurrency permit.
  • A queued continuous Graph request can hit its global timeout before admission. It is not removed from the throttler; if admitted later, it performs no write and permanently consumes the transferred permit.

Expected behavior

Track queued versus admitted ownership and return or remove the permit exactly once on every terminal path.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions