fix: report TLS from active channel handlers - #1011
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe configuration reporter API now accepts the active control connection channel. Sequence Diagram(s)sequenceDiagram
participant ProtocolInitHandler
participant DefaultDriverConfigReporter
participant NettyChannel
ProtocolInitHandler->>DefaultDriverConfigReporter: Pass startup options and control channel
DefaultDriverConfigReporter->>NettyChannel: Inspect active pipeline
NettyChannel-->>DefaultDriverConfigReporter: Return SslHandler state
DefaultDriverConfigReporter-->>ProtocolInitHandler: Populate configuration report
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
Derive TLS presence from the control channel pipeline after NettyOptions customization, so handlers added or removed by custom hooks are reported accurately. Compatibility note: this intentionally changes DriverConfigReporter, which is part of the explicitly unstable internal API. Keeping the channel-less contract would preserve an entry point that cannot report effective per-connection TLS state; custom internal reporters must be recompiled.
4618c81 to
240148d
Compare
Moves active-channel TLS detection out of #999.
The configuration report now derives whether TLS is enabled from the control channel pipeline after
NettyOptions.afterChannelInitialized, so custom hooks that add or remove anSslHandlerare reflected accurately. Hostname-verification behavior is otherwise unchanged.Compatibility note: this intentionally changes
DriverConfigReporter, which belongs to the explicitly unstable internal API. Keeping the channel-less contract would preserve an entry point that cannot report effective per-connection TLS state; custom internal reporters must be recompiled.Tests:
mvn -pl core -DskipITs -Dtest=DefaultDriverConfigReporterTest,ProtocolInitHandlerTest test