fix(core): validate CDN-supplied apiHost before building upload URL - #1312
Merged
Conversation
abueide
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateApiHost()toutil.ts— rejects anyapiHostvalue from the settings CDN that contains a scheme (https://,http://), credentials (user:pass@), query string (?), or fragment (#). Only barehost[/path]values (the format Segment CDN returns) are accepted.SegmentDestination.update(): invalidapiHostvalues are logged as an error and ignored, falling back to the default endpoint instead of interpolating attacker-controlled input into the upload URL.cdnProxy) could otherwise redirect all event uploads (write key + PII) to an attacker-controlled host.Test plan
validateApiHostunit tests: 3 positive cases (bare host, host/path, host:port/path) and 5 negative cases (scheme, credentials, query string, fragment, empty string)SegmentDestinationintegration test: 4 tamperedapiHostvalues all fall back todefaultApiHostuses segment settings apiHost for uploading eventstest confirms the valid path still worksyarn testinpackages/core— all tests pass🤖 Generated with Claude Code