Skip to content

Use Common Assembly Info in new assemblies - #1050

Draft
papeh wants to merge 2 commits into
mainfrom
fix/version-stamps
Draft

Use Common Assembly Info in new assemblies#1050
papeh wants to merge 2 commits into
mainfrom
fix/version-stamps

Conversation

@papeh

@papeh papeh commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

TODO: check whether any further assemblies, especially tests, should use this or AssemblyInfoForTests.cs

Quick Summary

CI-ready checklist

  • Commit messages follow .github/commit-guidelines.md (subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).
  • No whitespace warnings locally:
    git fetch origin
    git log --check --pretty=format:"---% h% s" origin/<base>..
    git diff --check --cached
  • Builds/tests pass locally (or I've run the CI-style build via Bash script or MSBuild).
  • If this is core-developer AI-assisted work, I followed Docs/workflows/ai-pr-workflow.md and ran pr-preflight or the equivalent branch-readiness review before requesting review.
  • For any Src/** folders touched, corresponding AGENTS.md files are updated or explicitly confirmed still accurate.

Notes for reviewers (optional)


This change is Reviewable

papeh and others added 2 commits August 7, 2026 12:10
TODO: check whether any further assemblies, especially tests, should
use this or AssemblyInfoForTests.cs
Pair the linked CommonAssemblyInfo.cs with GenerateAssemblyInfo=false so
the SDK stops generating duplicate assembly attributes, and add the same
link to FwAvalonia.Preview and the two Avalonia test projects.
Also exclude FwAvalonia.Preview.* from installer staging in both flows;
it is dev-only sample code that was never meant to ship.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   11m 49s ⏱️ +59s
5 761 tests ±0  5 680 ✅ ±0  81 💤 ±0  0 ❌ ±0 
5 770 runs  ±0  5 689 ✅ ±0  81 💤 ±0  0 ❌ ±0 

Results for commit af65b4a. ± Comparison against base commit 8dd2468.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.44%. Comparing base (8dd2468) to head (af65b4a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1050   +/-   ##
=======================================
  Coverage   36.43%   36.44%           
=======================================
  Files        1354     1354           
  Lines      295676   295692   +16     
  Branches    40223    40228    +5     
=======================================
+ Hits       107742   107756   +14     
+ Misses     158661   158656    -5     
- Partials    29273    29280    +7     

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants