Classify header parse errors as bad requests. - #113
Open
samuel-williams-shopify wants to merge 1 commit into
Open
Classify header parse errors as bad requests.#113samuel-williams-shopify wants to merge 1 commit into
samuel-williams-shopify wants to merge 1 commit into
Conversation
samuel-williams-shopify
force-pushed
the
classify-request-header-parse-errors
branch
from
August 2, 2026 11:13
ca811d3 to
2e54089
Compare
samuel-williams-shopify
changed the title
samuel-williams-shopify
force-pushed
the
classify-request-header-parse-errors
branch
from
August 2, 2026 11:40
2e54089 to
2595522
Compare
samuel-williams-shopify
force-pushed
the
add-range-header
branch
from
August 2, 2026 11:48
51dfa71 to
10e78be
Compare
samuel-williams-shopify
force-pushed
the
classify-request-header-parse-errors
branch
from
August 2, 2026 11:48
2595522 to
b9b17eb
Compare
samuel-williams-shopify
force-pushed
the
add-range-header
branch
from
August 2, 2026 11:50
10e78be to
5cbb622
Compare
samuel-williams-shopify
force-pushed
the
classify-request-header-parse-errors
branch
from
August 2, 2026 11:51
b9b17eb to
a1259db
Compare
samuel-williams-shopify
force-pushed
the
classify-request-header-parse-errors
branch
from
August 2, 2026 12:02
a1259db to
9f11e14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept,Accept-Charset,Accept-Encoding,Accept-Language,Digest,Range,Server-Timing, andTEasProtocol::HTTP::BadRequest.This PR is stacked on #112 so the
Rangeparser remains independent of this classification decision.Tests
bundle exec bake test(768 tests, 1,545 assertions, 100% coverage).bundle exec bake decode:index:coverage lib(438/438 definitions).Contribution