Fix v3 CI path filter case and remove stale files entry - #4465
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe workflow now uses lowercase API v3 test names. The package publication list no longer includes the Android common Java source directory. ChangesAPI v3 workflow
Published package contents
Merge Risk: ⚪ Minimal · up to The changes correct a case-sensitive CI path filter and remove a stale package file entry; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Corrects v3 CI test path casing and removes a stale Android package entry.
Changes:
- Updates workflow and Jest patterns to match
api_v3.test.tsx. - Removes the deleted Android source directory from package files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/react-native-gesture-handler/package.json |
Removes the stale Android directory entry. |
.github/workflows/rngh-api-v3.yml |
Corrects v3 test path and pattern casing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Description
Two small cleanups:
rngh-api-v3.ymlpointed atAPI_V3.test.tsx, but the file isapi_v3.test.tsxand GitHub path filters are case-sensitive, so a PR touching only the v3 test suite never triggered the workflow. The mismatch has been there since the workflow was added in HandletestIDprop #3838. Also lowercased the pattern in theyarn teststep to match the file literally (it worked before only because jest matches patterns case-insensitively).android/common/src/main/java/fromfilesinpackage.json- the directory was deleted in [Android] Update build tools #3544, npm silently ignores the unmatched entry.Test plan
npx jest --listTests RelationsTraversal api_v3still selects both test files.