Skip to content

Fix v3 CI path filter case and remove stale files entry - #4465

Open
m-bert wants to merge 2 commits into
mainfrom
@mbert/ci-packaging-cleanup
Open

Fix v3 CI path filter case and remove stale files entry#4465
m-bert wants to merge 2 commits into
mainfrom
@mbert/ci-packaging-cleanup

Conversation

@m-bert

@m-bert m-bert commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Description

Two small cleanups:

  • The path filter in rngh-api-v3.yml pointed at API_V3.test.tsx, but the file is api_v3.test.tsx and GitHub path filters are case-sensitive, so a PR touching only the v3 test suite never triggered the workflow. The mismatch has been there since the workflow was added in Handle testID prop #3838. Also lowercased the pattern in the yarn test step to match the file literally (it worked before only because jest matches patterns case-insensitively).
  • Removed android/common/src/main/java/ from files in package.json - the directory was deleted in [Android] Update build tools #3544, npm silently ignores the unmatched entry.

Test plan

  • npx jest --listTests RelationsTraversal api_v3 still selects both test files.

Copilot AI lite review requested due to automatic review settings August 21, 2026 14:04
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 703e0aa9-1017-42e6-abf3-4d4cec2d87b6

📥 Commits

Reviewing files that changed from the base of the PR and between 8a4d05d and 5f4752d.

📒 Files selected for processing (2)
  • .github/workflows/rngh-api-v3.yml
  • packages/react-native-gesture-handler/package.json
💤 Files with no reviewable changes (1)
  • packages/react-native-gesture-handler/package.json

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated automated testing to reference the correct API v3 test file and target.
    • Excluded an internal Android source directory from published package contents.

Walkthrough

The workflow now uses lowercase API v3 test names. The package publication list no longer includes the Android common Java source directory.

Changes

API v3 workflow

Layer / File(s) Summary
Lowercase API v3 test targeting
.github/workflows/rngh-api-v3.yml
The pull-request path filter and test command now use lowercase api_v3 names.

Published package contents

Layer / File(s) Summary
Remove Android source path from package contents
packages/react-native-gesture-handler/package.json
The published package files list no longer includes android/common/src/main/java/.

Merge Risk: ⚪ Minimal · up to 5f475

The changes correct a case-sensitive CI path filter and remove a stale package file entry; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies both the CI path filter fix and the stale package files entry removal.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Corrects v3 CI test path casing and removes a stale Android package entry.

Changes:

  • Updates workflow and Jest patterns to match api_v3.test.tsx.
  • Removes the deleted Android source directory from package files.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/react-native-gesture-handler/package.json Removes the stale Android directory entry.
.github/workflows/rngh-api-v3.yml Corrects v3 test path and pattern casing.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants