NH-145357 Fix tox runs at CI/CD - #839
Closed
tammy-baylis-swi wants to merge 2 commits into
Closed
tammy-baylis-swi wants to merge 2 commits into
tammy-baylis-swi wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to restore tox-based CI workflows running on pull requests after workflow-trigger changes introduced in PR #795 by adjusting the pull_request trigger configuration in the tox workflows.
Changes:
- Updates the
on.pull_requestevent filter key in tox workflows. - Attempts to control which PR events cause tox workflows to run.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/run_tox_tests.yaml | Modifies the pull_request trigger configuration for tox test runs |
| .github/workflows/run_tox_ruff_format.yaml | Modifies the pull_request trigger configuration for tox ruff formatting checks |
| .github/workflows/run_tox_lint_format.yaml | Modifies the pull_request trigger configuration for tox lint/format checks |
Comment on lines
+14
to
+15
| pull_request: | ||
| types: [opened, reopened] | ||
| type: [opened, reopened] |
Comment on lines
+14
to
+15
| pull_request: | ||
| types: [opened, reopened] | ||
| type: [opened, reopened] |
Comment on lines
+14
to
+15
| pull_request: | ||
| types: [opened, reopened] | ||
| type: [opened, reopened] |
This reverts commit 5947965.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes change in #795 that stopped tox-based workflows from running at PR CI/CD.