Skip to content

chore(ci): replace SourceKnight with setup-sp - #28

Merged
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight
Aug 18, 2026
Merged

chore(ci): replace SourceKnight with setup-sp#28
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight

Conversation

@Rushaway

Copy link
Copy Markdown
Member

Summary

  • Replace the SourceKnight-based build (maxime1907/action-sourceknight) with a native GitHub Actions CI workflow.
  • Compile with rumblefrog/setup-sp@v1.3.1, pinned to SourceMod 1.12.x.
  • Clone the VIP Core dependency (srcdslab/sm-plugin-VIP-Core) directly and copy its scripting includes before compiling VIP_Test.sp.
  • Keep the release packaging behavior: plugin .smx plus the translations directory, with auto-release tagged latest on pushes to master/main.
  • Remove sourceknight.yaml and the .sourceknight gitignore entry; update .github/copilot-instructions.md to describe the new build process.

Test plan

  • Confirm the CI workflow run on this PR builds VIP_Test.smx successfully.
  • Confirm the build artifact contains the plugin and translations.

Replace the SourceKnight-based build with native GitHub Actions,
compiling with rumblefrog/setup-sp pinned to SourceMod 1.12.x.
Copilot AI lite review requested due to automatic review settings August 17, 2026 18:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Rushaway
Rushaway merged commit 4a921c6 into master Aug 18, 2026
6 checks passed
@Rushaway
Rushaway deleted the chore/drop-sourceknight branch August 18, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants