Reset server MAC after TransformFinalBlock on .NET FW - #1830
Open
scott-xu wants to merge 1 commit into
Open
Conversation
scott-xu
requested review from
Rob-Hague,
WojciechNagorski and
drieseng
as code owners
August 22, 2026 15:07
Rob-Hague
reviewed
Aug 22, 2026
scott-xu
force-pushed
the
fix/initialize-mac-netframework
branch
from
August 24, 2026 13:14
b407a2d to
f8d1e3b
Compare
Add `#if NETFRAMEWORK` block to call `_serverMac.Initialize()` after `TransformFinalBlock` in `ReceiveMessage`. Ensures MAC is reset for reuse, addressing issues on older .NET Framework builds (e.g., mscorlib.dll 4.8.4110.0).
scott-xu
force-pushed
the
fix/initialize-mac-netframework
branch
from
August 24, 2026 13:18
f8d1e3b to
b0a4569
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
_serverMac.Initialize()afterTransformFinalBlockwhen running on .NET Framework. This ensures the MAC is properly reset, addressing differences in cryptographic API behavior across different versions of mscorlib.dll.Close #1829