feat: Enable auto-purge and set defaults - #1068
Open
xeniape wants to merge 3 commits into
Open
Conversation
1 task
Member
Author
|
I added the change as BREAKING in the changelog, but not sure. My reasoning was that it changes behavior, which might impact users and their assumptions of the data directory state. But if someone objects to that, that's fine too. |
Member
|
I think BREAKING is fine. We want to point people at behavior that can delete data, even if it's only old journals. |
Member
Author
|
Yeah, that was the plan after it gets approved and the exact changes are set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation for #1029
This PR only sets default values for the properties
autopurge.snapRetainCount,autopurge.purgeInterval(this one basically enables auto-purge),snapSizeLimitInKb, andpreAllocSize. The bulk of the PR is the additional docs explaining the feature and adding a reference page for the defaults.Verified that this feature works with a local kind cluster load test with smaller values. Snapshots were successfully deleted except for the 3 we keep.
Integrationtests
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker