Skip to content

Cherry pick changes to v1.148.0 - #176

Closed
hammadzf wants to merge 1 commit into
ske-v1.148.0from
v1.148.0-cherry-picks
Closed

Cherry pick changes to v1.148.0#176
hammadzf wants to merge 1 commit into
ske-v1.148.0from
v1.148.0-cherry-picks

Conversation

@hammadzf

@hammadzf hammadzf commented Aug 4, 2026

Copy link
Copy Markdown

/kind cherry-pick

What this PR does / why we need it:
See https://github.com/gardener/gardener/compare/release-v1.148...stackitcloud:gardener:v1.148.0-cherry-picks?expand=1
Part of STACKITSKE-8336

Which issue(s) this PR fixes:
ref gardener#15200

Special notes for your reviewer:
/cc @stackitcloud/ske-gardener

@ske-prow
ske-prow Bot requested a review from a team August 4, 2026 14:17
@ske-prow ske-prow Bot added the kind/cherry-pick This is a cherry-pick and should be documented as such label Aug 4, 2026
@ske-prow

ske-prow Bot commented Aug 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hammadzf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 4, 2026

@timebertt timebertt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this.
Usually, we use a minor-specific release branch instead of a patch-specific release branch: https://developers.stackit.schwarz/domains/runtime/ske/operations/gardener-upgrade/upgrade-guide/#rebasing-our-fork
I.e., the branch should be named ske-v1.148 instead of ske-v1.148.0.

Apart from that, https://github.com/gardener/gardener/releases/tag/v1.148.1 was released, which includes a fix/mitigation for the containerd-logrotate failures: gardener#15436. We definitely want to roll this out soon.

Hence, I suggest starting over with a new ske-v1.148 branch based on the v1.148.1 tag. WDYT?

@robinschneider

Copy link
Copy Markdown
Member

Closing this in favor of #177 as requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cherry-pick This is a cherry-pick and should be documented as such size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants