Cherry pick changes to v1.148.0 - #176
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
timebertt
left a comment
There was a problem hiding this comment.
Thanks for taking this.
Usually, we use a minor-specific release branch instead of a patch-specific release branch: https://developers.stackit.schwarz/domains/runtime/ske/operations/gardener-upgrade/upgrade-guide/#rebasing-our-fork
I.e., the branch should be named ske-v1.148 instead of ske-v1.148.0.
Apart from that, https://github.com/gardener/gardener/releases/tag/v1.148.1 was released, which includes a fix/mitigation for the containerd-logrotate failures: gardener#15436. We definitely want to roll this out soon.
Hence, I suggest starting over with a new ske-v1.148 branch based on the v1.148.1 tag. WDYT?
|
Closing this in favor of #177 as requested |
/kind cherry-pick
What this PR does / why we need it:
See https://github.com/gardener/gardener/compare/release-v1.148...stackitcloud:gardener:v1.148.0-cherry-picks?expand=1
Part of STACKITSKE-8336
Which issue(s) this PR fixes:
ref gardener#15200
Special notes for your reviewer:
/cc @stackitcloud/ske-gardener