Feat/stackitsdk 517 service deletion - #290
Open
cgoetz-inovex wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce go build tool to generate and read plans.
Use go build tool to create service deletion PRs.
Review Instructions
feat(ci): create PRs for deleted branches, unify plan locationcreates PRs for deleted services and contains new codefeat(ci): sdk-create-pr does not push/create PR when NO_PUSH is setadds a NO_PUSH option to create-pr for easier local testingTesting Instructions
Testing refactorings:
diffoscope --no-default-limits --markdown diff-python.md --max-diff-block-lines 10000 --max-report-size 0 --exclude "**/.git" --exclude-command "stat.*" --exclude "**/.venv" --exclude "**/.gradle" base-python-sdk branch-python-sdk/Testing service deletion:
make download-oasandmake generate-go-sdkNO_PUSH=1 scripts/sdk-create-pr.sh foo barTestscript: