bench: update benchmarks to use decimal literals - #13859
Merged
Merged
Conversation
Propagates fix from 22fe7a6 ("bench: update benchmarks to use decimal literals") to sibling packages passing integer literals as floating-point bounds in calls to `@stdlib/random/array/uniform`. Affected packages: - blas/ext/base/csum - blas/ext/base/csumkbn - blas/ext/base/ddiff - blas/ext/base/dediff - blas/ext/base/gdiff - blas/ext/base/gediff - blas/ext/base/sdiff - blas/ext/base/sediff - blas/ext/base/zsum - blas/ext/base/zsumkbn - lapack/base/disnan - lapack/base/dlaisnan - lapack/base/dlapy2 - lapack/base/dlapy3 - math/base/special/hypot
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
August 2, 2026 20:27
kgryte
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
developbetween 2026-08-01T13:55:59-07:00 (5b3b59d5e) and 2026-08-02T03:50:29-07:00 (ca056bafc) to sibling packages.Fixes benchmark call sites in
blas/ext/base/{sdiff,sediff,ddiff,dediff,gdiff,gediff,csum,csumkbn,zsum,zsumkbn},lapack/base/{disnan,dlaisnan,dlapy2,dlapy3}, andmath/base/special/hypotthat 22fe7a6 missed: floating-point bounds passed touniformfrom@stdlib/random/array/uniformnow use decimal literals (e.g.,-100→-100.0,100→100.0), matching project convention.hypotfalready received this treatment in the original commit;hypotdid not. Same transformation, 42 files, 90 call sites, no other changes.Source commit: 22fe7a6 ("bench: update benchmarks to use decimal literals", #13849). Target packages:
blas/ext/base/csumblas/ext/base/csumkbnblas/ext/base/ddiffblas/ext/base/dediffblas/ext/base/gdiffblas/ext/base/gediffblas/ext/base/sdiffblas/ext/base/sediffblas/ext/base/zsumblas/ext/base/zsumkbnlapack/base/disnanlapack/base/dlaisnanlapack/base/dlapy2lapack/base/dlapy3math/base/special/hypotRelated Issues
No related issues.
Questions
No.
Other
Validation performed:
benchmark/*.jsfiles repo-wide, anchored to calls ofuniformfrom@stdlib/random/array/uniformwith integer literal bounds;discreteUniformcall sites (where integer literals are intentional) excluded by anchoring.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated fix-propagation routine: candidate sites were located by pattern search and each site was verified by independent validation passes before the mechanical transformation was applied.
Generated by Claude Code