Wire JavaScript Checkout controllers - #2584
Draft
porter-stripe wants to merge 11 commits into
Draft
porter-stripe wants to merge 11 commits into
porter-stripe wants to merge 11 commits into
Conversation
porter-stripe
commented
Aug 25, 2026
Comment on lines
+57
to
+60
| // TODO(porter): Uncomment when the reviewed native line item ships. | ||
| // putMap("unitAmountDecimal", amount(lineItem.unitAmountDecimal, session.currency)) | ||
| // putString("unitLabel", lineItem.unitLabel) | ||
| // putMap("adjustableQuantity", serializeAdjustableQuantity(lineItem.adjustableQuantity)) |
Collaborator
Author
There was a problem hiding this comment.
Android hasn't yet added some properties that are flagged with TODOs.
porter-stripe
force-pushed
the
porter/checkout-controller-creation
branch
from
August 25, 2026 16:39
4026a56 to
857de91
Compare
porter-stripe
marked this pull request as ready for review
August 25, 2026 17:25
Collaborator
|
Could you split this PR into more easily reviewable chunks? |
Base automatically changed from
porter/checkout-configuration-mapping
to
master
September 14, 2026 14:12
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
porter-stripe
force-pushed
the
porter/checkout-controller-creation
branch
from
September 14, 2026 14:12
b77f761 to
d2d91ba
Compare
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
This was referenced Sep 14, 2026
porter-stripe
removed this pull request from stack #2580
September 14, 2026 14:27
porter-stripe
changed the base branch from
master
to
porter/checkout-native-controllers
September 14, 2026 14:27
porter-stripe
added this pull request to stack #2640
September 14, 2026 14:27
porter-stripe
changed the title
…t-controller-creation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
…t-controller-creation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
…t-controller-creation
porter-stripe
removed this pull request from stack #2640
September 14, 2026 16:38
porter-stripe
added this pull request to stack #2643
September 14, 2026 16:38
porter-stripe
marked this pull request as draft
September 14, 2026 21:34
Collaborator
Author
|
@gbirch-stripe yep split this one up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires
createCheckoutto the native bridge and returns a stable JavaScript controller backed by ordered session snapshots. Scopes event buffering to pending creations and releases event state on failure or destruction. Mutation, confirmation, and presentation methods remain follow-ups.Review order: #2641 (Android serialization), #2638 (iOS serialization), #2642 (iOS lifecycle), #2639 (Android lifecycle), then #2584 (JavaScript).
Motivation
CheckoutSessions
Testing
Documentation