Conversation
… get handler logic
…lementation # Conflicts: # Package@swift-6.0.swift
|
@czechboy0 @FranzBusch can you review this? |
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
Thanks! This mostly looks good but I left some feedback inline which needs addressing.
…ndle validations that throw exceptions
…rk.framework scenarios
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
This is looking good, just a couple of small things left. The e2e tests are much better now as well 👍
- Pure HTTP requests (without TLS) when tlsPinning is configured globally. - HTTPS requests made via proxy (HTTP/SOCKS) on Apple platforms, even though the actual TLS is performed using NIOSSL (which supports pinning correctly).
|
I've marked this PR as a draft because I've identified some deeper architectural concerns with the original implementation. Specifically, it feels conceptually off to bundle the entire SSL Pinning functionality within the scope of If we look at Because of these details, I'm stepping back to re-evaluate the approach. I'm exploring a deeper, more decoupled solution, similar to how Thank you all for the reviews and the great discussions. I apologize for the extra effort and rework this pivot has caused on your end. |
2 participants
This PR introduces SPKI-based certificate pinning to
AsyncHTTPClientto mitigate MITM attacks and compromised CAs.Highlights:
.strictand.auditmodes with multi-algorithm hashing (SHA-256/384/512) and constant-time comparison.