fix(core): guard event unlisten script when listener entry is missing - #15800
Open
lazerg wants to merge 1 commit into
Open
fix(core): guard event unlisten script when listener entry is missing#15800lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
listen()resolves once Rust answers its invoke, but the webview registry entry is written by a separate, later eval, so the returned unlisten function can run before that entry exists. In that window the generated unlisten script readhandlerIdoff an undefined entry and threw, and because that throw happens before_unlistensends the backendplugin:event|unlisten, the listener stayed registered and kept firing. This checks the entry is present before reading it, the same guard the event delivery script already uses.Fixes #15799