Skip to content

Fix notification preferences and retention - #267

Merged
arjunkomath merged 2 commits into
mainfrom
fix/notification-alert-retention
Aug 3, 2026
Merged

Fix notification preferences and retention#267
arjunkomath merged 2 commits into
mainfrom
fix/notification-alert-retention

Conversation

@arjunkomath

@arjunkomath arjunkomath commented Aug 3, 2026

Copy link
Copy Markdown
Member

Summary

  • apply alert-category toggles consistently to email and in-app notifications
  • clarify notification settings copy across both channels
  • delete notifications read more than 30 days ago with a daily Inngest cron
  • report the cleanup count from PostgreSQL without returning deleted rows

Verification

  • pnpm exec vitest run tests/notifications.test.ts tests/inngest-route.test.ts
  • ./node_modules/.bin/tsc --noEmit
  • Biome check on touched files

Basecamp: https://app.basecamp.com/5890597/buckets/47439993/todos/10158024611

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

React Doctor found no issues. 🎉

⚠️ Warning: .github/workflows/react-doctor.yml is configured incorrectly. See below to fix.

React Doctor compares against main to report only the issues this pull request introduces. This run couldn't complete that comparison (usually a shallow CI checkout with no merge base), so it listed every issue in the changed files, including ones that already existed on main.

Add fetch-depth: 0 to the actions/checkout step in .github/workflows/react-doctor.yml so the checkout includes the history React Doctor needs:

 jobs:
   react-doctor:
     steps:
       - uses: actions/checkout@v5
+        with:
+          fetch-depth: 0

       - uses: millionco/react-doctor@v2

To silence this warning, set silence-missing-baseline-warning: true on the React Doctor action.

Reviewed by React Doctor for commit d594c5c.

@arjunkomath
arjunkomath added this pull request to the merge queue Aug 3, 2026
Merged via the queue into main with commit e000e56 Aug 3, 2026
8 checks passed
@arjunkomath
arjunkomath deleted the fix/notification-alert-retention branch August 3, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants