feat(observability): added section for using global tags across SDKs - #5270
Draft
flippedcoder wants to merge 3 commits into
Draft
feat(observability): added section for using global tags across SDKs#5270flippedcoder wants to merge 3 commits into
flippedcoder wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview links
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The documentation scope, placement, title, and incident narrative need revision before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds Python SDK documentation for applying low-cardinality global tags to emitted metrics.
Changes:
- Documents
TelemetryConfig.global_tagswith an example. - Adds tag-selection and diagnostic guidance.
- Updates the page title and table-of-contents depth.
File summaries
| File | Description |
|---|---|
docs/develop/python/platform/observability.mdx |
Adds global-tag guidance. Retain the Python title qualifier, align the stated cross-SDK scope, move shared policy to Best practices, and tighten the incident narrative. |
Review details
Suppressed comments (1)
docs/develop/python/platform/observability.mdx:75
- This organization-wide tag taxonomy and the incident/cost-allocation discussion below are SDK-independent prescriptive guidance. The information architecture says Develop pages should stay focused on accomplishing a task in a specific language, while organizational standards belong under Best practices (
readme/INFORMATION-ARCHITECTURE.md:21-29,71-75). Move this shared guidance to a Best practices page and link to it here, leaving only the Python API and example on this page; otherwise the same policy will be duplicated across every SDK page.
#### Choose a tag set
Tags group metrics only when every Worker across your organization emits the same keys, so decide on the set before teams adopt it.
These five suit most organizations:
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
flippedcoder
force-pushed
the
mm/global-tags
branch
from
September 8, 2026 18:55
64eec7b to
d9a15c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds a section on each SDK's
observabilitypage to describeglobalTags.Notes to reviewers