feat: implement the driver status hook - #253
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kitchen listhad nothing to report for this driver beyond what the state file remembered, becauseKitchen::Driver::Base#statuswas never overridden.Nova is now asked directly, so a server that was deleted out from under Test Kitchen, or is stuck in
BUILD, or has gone toERROR, is visible without a converge.liveis true only forACTIVE, matching fog's ownready?.Three cases fall back to the base "unknown" answer rather than raising, because
kitchen listshould never blow up on a driver it is merely interrogating: no server in state, Nova does not know the id, and the cloud cannot be reached. The lookup honoursdisable_ssl_validationthe same waycreateanddestroydo.A note on
superKitchen::Driver::Base#statusonly exists in Test Kitchen 4.1.0 and later, and only 4.1.0+ callsdriver.status, so thesupercalls are unreachable on a version that lacks them. This matches the pattern already in kitchen-cloudstack, kitchen-ec2, and kitchen-google.Verification
rake test— 367 examples, 0 failures (360 before; 7 new),rakeexit 0cookstyle --chefstyle— 11 files, no offensesyard stats— 100% documented