feat: implement the driver doctor hook - #254
Merged
Merged
Conversation
tas50
force-pushed
the
feat/doctor-hook
branch
from
August 24, 2026 03:03
a26c8d0 to
9d47b6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kitchen doctorhad nothing to say for this driver. Two groups of checks, both about failures that currently arrive part way throughcreate.Credentials.
openstack_username,openstack_api_key, andopenstack_auth_urlare inrequired_server_settings, but that only means Fog is handed them even when nil — nothing rejects a nil before the request goes out, so a missing password becomes a Keystone rejection mid-create. Each message names the setting and every place it can legitimately come from, since this driver reads three:When all three are present, they are actually exercised against Keystone.
Image and flavor selection.
createraises on these:doctorreports the same conflicts before the run starts, and also catches the inverse — neither set, which is not currently checked anywhere and fails later and less clearly.The connectivity check is skipped when credentials are missing: "could not authenticate" stacked on "no password is set" is noise, and there is a test pinning that it stays quiet.
Verification
rake test— 367 examples, 0 failures (360 before; 7 new),rakeexit 0cookstyle --chefstyle— 11 files, no offensesyard stats— 100% documented