Keep overnight runs from dying silently on stray rejections - #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nightly runs were dying mid-test after ~3.5 hours with no error anywhere. Telemetry flush fix proved the process just stops between steps. In Bun an unhandled promise rejection kills the whole process, which fits the evidence perfectly, so those are now logged loudly (full stack) and the run continues; an uncaught exception logs its stack, flushes telemetry and exits with code 1 instead of dying bare. If the killer turns out to be external (OOM/SIGKILL), the absence of any handler trace is itself the diagnosis.