KPDR safeties first beta release - #286
Draft
idlechild wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
I got a request for documentation and I think that's a good idea. I'm going to try to add a new webpage, but not linked from the main page just yet. That way I can just post a wall of text there and reference it from discord instead of posting wall of text to discord. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I should probably add a comment about the difference between an energy adjustment and a refill adjustment. Energy adjustments play nice with other safeties, but sometimes you need the refill adjustment which does an overwrite. Not sure where to put those comments though.
Also I expect there will be some adjustments before this is ready for release. I'd also like to add phantoon-first safeties, but probably not going further than that.