Fix potential crash when loading presets - #291
Open
InsaneFirebat wants to merge 1 commit into
Open
Conversation
$82E139 was overwritten for the hitbox viewer color feature
Collaborator
|
Good find This ended up being so minor I'm wondering if it's worth merging now (I'm not opposed to it) |
Collaborator
Author
|
It's on next-update now. I don't think it will crash but I didn't bother checking where the negative flag actually came from. It's passing through some PHP/PLP in the routine before it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was experimenting with making demos load faster in the practice hack by copying
preset_start_gameplay. I came across a crash after cutting out some things that were specific to presets. The hitbox color feature overwrote a stray RTL to expand the routine below it.preset_start_gameplaywas calling the old address. The routine is supposed to start like thisBut it worked out to this on the first loop
We don't notice the effects of this because X = $20, only one extra loop. The fix is replacing
JSL $82E139withJSL load_common_target_colorsin presets.asm