Only define THRESHOLD once - #322
Open
joshuagl wants to merge 5 commits into
Open
Conversation
theupdateframeworkGH-314 introduced a second definition of THRESHOLD _without_ a <dfn> tag. There are two ways we can fix this: 1. introduce a second dfn tag and use a for attribute on each definition, i.e., <dfn for="root"> 2. streamline to a single definition and update the DELEGATIONS definition to reference the THRESHOLD definition in the root section I've opted for 2 here as it's simpler and avoids redundant duplicate definitions. Signed-off-by: Joshua Lock <joshuagloe@gmail.com>
We have two definitions of KEYID and, by default, we get a random one at build time if the `for` attribute is not specified on the anchor (<a>) element. Squash randomness by always referring to the KEYID definition for the root role. Signed-off-by: Joshua Lock <joshuagloe@gmail.com>
This will prevent bikeshed releases unintentionally breaking our builds without anyone noticing until a CI workflow with additional changes is run. Signed-off-by: Joshua Lock <joshuagloe@gmail.com>
Changed role, updating affiliation Signed-off-by: Joshua Lock <joshuagloe@gmail.com>
Signed-off-by: Joshua Lock <joshuagloe@gmail.com>
joshuagl
marked this pull request as ready for review
August 5, 2026 15:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#314 is a great clarification, however it also introduced a second definition of THRESHOLD without a tag. This definition is duplicative and gets lost because it's not marked up as other definitions.
There are two ways we can fix this:
i.e.,
to reference the THRESHOLD definition in the root section
I've opted for 2 here as it's simpler and avoids redundant duplicate definitions, but please let me know if you would prefer 1.
As well as this, I ended up doing some cleanup in this PR: