Version Packages - #8888
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
WalkthroughThe PR records the thirdweb 5.121.0 release. It documents redirect-login state verification, URL token opt-out support, listener removal, injected-wallet disconnect handling, and SIWE validation. It updates versions and changelogs for thirdweb, Nebula, the wagmi adapter, and the wagmi demo. ChangesRelease metadata
Estimated code review effort: 1 (Trivial) | ~5 minutes Mergeability Score: ⚪ Minimal · up to This release updates package versions and changelogs without any identified merge-blocking risk; it is merge-ready after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8888 +/- ##
=======================================
Coverage 52.46% 52.47%
=======================================
Files 935 935
Lines 63083 63083
Branches 4148 4149 +1
=======================================
+ Hits 33097 33102 +5
+ Misses 29884 29879 -5
Partials 102 102
🚀 New features to boost your workflow:
|
45c1b9a to
6ab94e0
Compare
6ab94e0 to
fd5ba74
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
thirdweb@5.121.0
Minor Changes
133e57dThanks @0xFirekeeper! - Redirect-based in-app wallet logins now include and verify a one-timestatevalue beforeAutoConnectconsumes auth material returned in the URL, tying the returned token back to a flow the page actually started. Added areadUrlTokenoption toAutoConnect/useAutoConnectto opt out of reading wallet auth material from the URL entirely.Patch Changes
#8886
e4fba08Thanks @blockgroot! - Fix:EIP1193.toProvider()'sremoveListeneris no longer a no-op. Previously,removeListenerdiscarded the unsubscribe function returned bywallet.subscribe(), so listeners registered viaprovider.on(...)(e.g.accountsChanged,chainChanged,disconnect) could never actually be detached — they kept firing after callers (such as wagmi connectors) believed they had unsubscribed.removeListenernow tracks and invokes the correct unsubscribe function per(event, listener)pair.#8807
8c521aaThanks @Yash094! - Fix: injected wallets (e.g. MetaMask) no longer fire a spurious"disconnect"event for transient EIP-1193 error code 1013 ("disconnected, will reconnect"). Previously, MetaMask's temporary disconnect during chain changes or RPC hiccups would trigger the thirdwebdisconnectsubscriber and tear down wallet state, causing unexpected logouts. TheonDisconnecthandler now ignores code-1013 errors and lets MetaMask reconnect automatically.Additionally, the
WalletEmitterEvents["disconnect"]type is updated fromnevertoWalletDisconnectError | undefined, sodisconnectsubscribers can inspect the underlying EIP-1193 error code and message when they need to distinguish disconnect causes.#8875
f411769Thanks @SashaMIT! - Reject SIWE login payloads with an unparseable Not Before or Expiration Time instead of skipping the time-bound checks.@thirdweb-dev/nebula@0.2.117
Patch Changes
133e57d,e4fba08,8c521aa,f411769]:@thirdweb-dev/wagmi-adapter@0.2.214
wagmi-inapp@0.0.59
Patch Changes
133e57d,e4fba08,8c521aa,f411769]:PR-Codex overview
This PR primarily focuses on updating version numbers across several packages and includes notable changes in functionality and bug fixes related to wallet connections and event handling.
Detailed summary
versioninpackages/thirdweb/package.jsonfrom5.120.1to5.121.0.versioninapps/wagmi-demo/package.jsonfrom0.0.58to0.0.59.versioninpackages/nebula/package.jsonfrom0.2.116to0.2.117.versioninpackages/wagmi-adapter/package.jsonfrom0.2.213to0.2.214.nebula,wagmi-demo, andthirdwebdetailing patch changes and bug fixes.EIP1193.toProvider()to correctly handleremoveListenerfunctionality."disconnect"events for injected wallets, enhancing user experience during transient errors.