Fix delegation ordering in token burn tests - #189
Open
mswilkison wants to merge 1 commit into
Open
mswilkison wants to merge 1 commit into
mswilkison wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared burn-test setup started delegation without awaiting it, allowing
burnorburnFromto execute before voting power was delegated. Await both delegation calls so the existing event assertions observe the intended ordering.Closes #111.
Validation: all 106 token tests pass on the existing Hardhat 2.10 / ethers 5 stack. A temporary timing harness delayed delegation submission by 100 ms: all four affected event tests failed with the original code and all four passed with this fix. Modified-file ESLint, Prettier, and
git diff --checkpass. Gas reporting was disabled locally because its reporter requires a listening socket in the sandbox; the contract tests ran on the in-memory Hardhat network.