Skip to content

Unify @keep-network/hardhat-helpers pin, repoint to threshold-network fork - #193

Open
piotr-roslaniec wants to merge 1 commit into
mainfrom
bump-hardhat-helpers
Open

piotr-roslaniec wants to merge 1 commit into
mainfrom
bump-hardhat-helpers

Conversation

@piotr-roslaniec

Copy link
Copy Markdown
Contributor

What

Unifies this repo's @keep-network/hardhat-helpers devDependency pin onto the same exact version used across the org's other consumers, and repoints from the npm registry to a new org-owned fork since the upstream package (keep-network/hardhat-helpers) is unmaintained.

Location updated (1)

Location Old pin New pin
/ (root package.json) ^0.6.0-pre.8 github:threshold-network/hardhat-helpers#v0.6.0-pre.21

Why this target version, and why a fork

  • Newest npm-published version is 0.7.2, but 0.7.0+ requires an incompatible ethers ^6.10.0 upgrade (confirmed via diffing src/upgrades.ts and registry peerDependencies). This repo is still on ethers v5 tooling, so bumping to 0.7.x would silently fold in an unrelated, much larger migration.
  • 0.6.0-pre.21 is the newest npm-published prerelease with byte-identical, ethers-v5-compatible peerDependencies to 0.6.0-pre.20, and is the version used elsewhere across the org's other hardhat-helpers consumers (see companion PRs in keep-core and tbtc-v2).
  • Upstream keep-network/hardhat-helpers is unmaintained; forked to threshold-network/hardhat-helpers (tag v0.6.0-pre.21, verified byte-identical in content to the npm-published 0.6.0-pre.21 tarball) so this org isn't dependent on someone else's registry publishing.

Full analysis: agent-docs/prep/p5-hardhat-helpers.md in threshold-network/keep-common.

Verification

  • This consumer's real coupling is to helpers.number, helpers.address.isValid, helpers.ownable.transferOwnership, helpers.time, helpers.signers across deploy scripts and test suites — none of these modules changed behavior between the old pin's era and 0.6.0-pre.21 (confirmed via registry peerDependencies comparison in the prep doc; no helpers.upgrades usage in this repo).
  • Lockfile is intentionally not regenerated in this PR — should be regenerated via yarn install/npm install as part of landing this change, matching normal repo convention.

… fork

Was pinned to ^0.6.0-pre.8. Unified on the same exact version,
0.6.0-pre.21, used across the org's other hardhat-helpers consumers (see
agent-docs/prep/p5-hardhat-helpers.md in threshold-network/keep-common
for the full version-selection analysis: 0.6.0-pre.21 is the newest
npm-published prerelease that stays on the ethers v5 peer-dependency
generation this consumer still uses; 0.7.x+ requires an incompatible
ethers v6 migration).

Repointed from the npm registry to the new org-owned fork
threshold-network/hardhat-helpers (upstream keep-network/hardhat-helpers
is unmaintained) at tag v0.6.0-pre.21, verified byte-identical to the
npm-published 0.6.0-pre.21 tarball content.

Lockfiles are not regenerated in this PR - this location should
regenerate via yarn/npm install as part of landing this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant