Make helper cancellation and save-data ownership explicit - #13
Open
mswilkison wants to merge 2 commits into
Open
mswilkison wants to merge 2 commits into
mswilkison wants to merge 2 commits into
Conversation
Adapt the result handoff in common/safe_prime.go from public upstream commit 24bb7d3. Add bounded worker lifecycle tests for cancellation with no receiver and a full result buffer, plus ordinary result delivery. Test cleanup drains pending results and joins workers.
Adapt Xi and ShareID copying from public upstream commit 04bb840 and the roster-content guard from 1693884, limited to ecdsa/keygen/save_data.go. Preserve nil local secrets and existing pre-parameter and per-party pointer sharing. The nil saved-key diagnostic and focused ownership, subset-selection, and input-guard unit tests are additions for this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow safe-prime workers to observe cancellation during result delivery. Give ECDSA save-data subsets independent copies of
XiandShareID, preserving nil, and report nil saved keys or missing roster content with named diagnostics. Other pre-parameter and per-party object sharing remains documented.Adapted from public upstream commits
24bb7d379f262294cb1422532d26b77f20939ac8,04bb840ad562822962fc87371b82e608784fbb71, and the roster guard in16938849b0f49bf925ea3902f5fab21b9ea9904b. The nil saved-key diagnostic and focused tests are local additions.Validation: full
common, focused cancellation/ownership tests, andecdsa/keygenexcludingTestE2EConcurrentAndSaveFixturespassed. The full keygen attempt reached Go's default ten-minute timeout in that existing 20-party E2E test during proof verification. Tests usedGOMAXPROCS=2and-p 1; formatting, diff checks, and independent patch review passed.