You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On staging we have a bunch of redirects which all point to a torchbox.com url. This is as a result of importing the production data. It's potentially very confusing, as people might not notice the redirect - and in a worst case scenario they might accidentally edit a live page with a test thinking they are on staging. This PR adds a management command that allows you to delete all redirects pointing to a http://torchbox.com url. At the moment it excludes any media.torchbox.com redirects.
How to Test
Try running the script in your local build. Note that as a precaution it can't be run in production.
Screenshots
Expand to see more
MR Checklist
Add a description of your pull request and instructions for the reviewer to verify your work.
If your pull request is for a specific ticket, link to it in the description.
Stay on point and keep it small so the merge request can be easily reviewed.
q: would it not make more sense to replace with the staging domain?
Also, what are the safeguards against running this in prod? e.g. it may be more fitting as a birdbath extension
q: would it not make more sense to replace with the staging domain?
We could do - but to be honest there are hundreds of old redirects and I think it just makes more sense to not have them on staging - e.g. there are ones created as shortlinks for webinars.
q: Also, what are the safeguards against running this in prod? e.g. it may be more fitting as a birdbath extension
It checks the sentry env with if sentry_env == "production": - I hadn't thought of making it part of birdbath. If I get a sec I will try doing that instead. It might be good though to be able to run this on staging sooner rather than later as there is a danger of people accidentally landing on production and making test changes when they think they are on staging.
It might be good though to be able to run this on staging sooner rather than later as there is a danger of people accidentally landing on production and making test changes when they think they are on staging.
perphas best done via the CLI as a one-off?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes Made
On staging we have a bunch of redirects which all point to a torchbox.com url. This is as a result of importing the production data. It's potentially very confusing, as people might not notice the redirect - and in a worst case scenario they might accidentally edit a live page with a test thinking they are on staging. This PR adds a management command that allows you to delete all redirects pointing to a
http://torchbox.comurl. At the moment it excludes any media.torchbox.com redirects.How to Test
Try running the script in your local build. Note that as a precaution it can't be run in production.
Screenshots
Expand to see more
MR Checklist
Unit tests
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library