docs(agents): persist independent review reports - #2166
Open
josecelano wants to merge 7 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2166 +/- ##
===========================================
- Coverage 84.98% 84.97% -0.01%
===========================================
Files 351 351
Lines 29139 29139
Branches 29139 29139
===========================================
- Hits 24764 24762 -2
- Misses 4020 4022 +2
Partials 355 355 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Adds a standardized, append-only mechanism for persisting independent reviewer reports alongside folder-style issue specifications, and wires that workflow into agent profiles and documentation with a contract-test to enforce structure.
Changes:
- Introduces
AGENT-REVIEW-REPORTS.mdtemplate and documents when/where independent review reports must be recorded. - Updates reviewer agent profiles and orchestration docs to require creating/appending
agent-review-reports.mdfor folder-style specs. - Adds a bash contract test and seeds issue #2160 with sequential sample report entries plus spec progress/AC updates.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/templates/ISSUE.md | Adds checklist and guidance to record issue-local independent review reports for folder-style specs. |
| docs/templates/AGENT-REVIEW-REPORTS.md | New reusable append-only report template with required fields and verdict vocabulary. |
| docs/issues/open/2160-2003-persist-independent-agent-review-reports/agent-review-reports.md | Adds initial sequential report entries (Complexity Auditor + Task Reviewer) as evidence for #2160. |
| docs/issues/open/2160-2003-persist-independent-agent-review-reports/ISSUE.md | Updates status/progress, acceptance criteria, and verification evidence to reflect implemented workflow. |
| docs/index.md | Links the new agent review reports template from the canonical templates table. |
| docs/agents/orchestration.md | Updates handoff/ownership tables to include issue-local review reports and optional commit path for failed-review evidence. |
| docs/AGENTS.md | Updates directory map description of templates to include agent review reports. |
| contrib/dev-tools/checks/tests/test-agent-review-report-contract.sh | Adds structural contract test to enforce template/profile requirements and separation from Copilot tracker. |
| .github/agents/task-reviewer.agent.md | Requires persisting review reports for folder-style specs; adds detailed persistence instructions. |
| .github/agents/pr-reviewer.agent.md | Requires persisting PR review reports for folder-style specs; clarifies independence from Copilot tracker. |
| .github/agents/implementer.agent.md | Documents how persisted reports and checkbox updates should flow into the Committer handoff. |
| .github/agents/complexity-auditor.agent.md | Grants edit and adds persistence policy/constraints for issue-local reporting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
edittool and document caller-to-Committer ownership for report commits;Validation
bash contrib/dev-tools/checks/tests/test-agent-review-report-contract.sh./contrib/dev-tools/git/hooks/pre-commit.sh --format=jsonlinter allcargo test --doc --workspaceCloses #2160
Related to #2003