Skip to content

fix: keep Modal portals accessible - #3576

Open
rswerve wants to merge 1 commit into
mainfrom
ma-modal-portal-safety-3575
Open

rswerve wants to merge 1 commit into
mainfrom
ma-modal-portal-safety-3575

Conversation

@rswerve

@rswerve rswerve commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • defer portal creation until Modal mounts so server rendering never reads document
  • keep the body child containing an open portal modal exposed to assistive technology
  • cover both regressions and document the default #modal-root behavior

Related Issues or PRs

Closes #3575

How To Test

  • npm test
  • npm run lint
  • npm run format:check
  • npm run test:coverage
  • npm run build
  • npm run test:serverside
  • npm run build-storybook

Screenshots (optional)

Not applicable.

Author & Maintainer checklist

  • Is this is a breaking change?
    • Yes, and I accounted for the breaking changes according to the linked documentation
    • No
  • Once merged, add the PR and Issue author(s) as a contributor(s) via the all-contributors bot

@rswerve
rswerve requested review from a team as code owners August 10, 2026 21:41
@github-actions

Copy link
Copy Markdown
Contributor
Warnings
⚠️ It looks like there are new component (JSX/TSX) files, but the entrypoint (index.ts) has not changed. - Did you forget to export new components from the library entrypoint?

Generated by 🚫 dangerJS against ff4ee97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] Keep Modal portal rendering server-safe and accessible

1 participant