Preserve final-only pipeline visualizations - #29
Open
ugin-man wants to merge 1 commit into
Open
Conversation
|
@ugin-man is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A solved pipeline with no stages and no initial visualization discards the graphics returned by
finalVisualize():visualize()returns its empty fallback before appending the final result.Append the final visualization before checking for an empty result. Add regression coverage for the final-only case, an unsolved pipeline, and a solved pipeline without visualization hooks.
Validation: the new final-only regression fails before the fix; all 25 tests (95 assertions) pass after it.
tsc --noEmitandbun run buildpass.Prepared with Codex (Astra) assistance and verified locally.