Show text-only and arrow-only solver graphics - #32
Open
ugin-man wants to merge 1 commit into
Open
Conversation
|
@ugin-man is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debugger checks points, lines, rectangles, and circles to decide whether a visualization is empty, but omits the supported
textsandarrowsarrays. A solver returning only a text annotation or only arrows therefore shows “No Graphics Yet”.Include both arrays in the emptiness check. Component rendering tests verify that text-only and arrow-only visualizations reach the renderer, while empty graphics still show the placeholder. The tests provide minimal browser APIs needed by the interactive renderer during initial rendering.
Validation: both display regressions fail against the original code. All 25 tests (94 assertions),
tsc --noEmit, andbun run buildpass with the fix.Prepared with Codex (Astra) assistance and verified locally.