Conversation
|
@ugin-man is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a stage reports failure,
BasePipelineSolversets its ownfailedflag and clearsactiveSubSolver. The stage table then classifies the current stage as “Not Started”, hiding the failure. A stage constructor that throws has the same result because no active solver is assigned.Check the pipeline's failure flag for the current stage before inspecting the active solver. Later stages remain “Not Started”, and normal initialization still transitions to “In Progress”.
Validation: two regressions using actual pipeline execution fail before the fix. All 25 tests (96 assertions),
tsc --noEmit, andbun run buildpass after the change.Prepared with Codex (Astra) assistance and verified locally.