Skip to content

Preserve arrows when combining pipeline visualizations - #35

Open
ugin-man wants to merge 3 commits into
tscircuit:mainfrom
ugin-man:koyo/preserve-pipeline-arrows-20260909
Open

Preserve arrows when combining pipeline visualizations#35
ugin-man wants to merge 3 commits into
tscircuit:mainfrom
ugin-man:koyo/preserve-pipeline-arrows-20260909

Conversation

@ugin-man

@ugin-man ugin-man commented Sep 8, 2026

Copy link
Copy Markdown

BasePipelineSolver.visualize() preserves arrows when returning one stage directly, but drops them as soon as it combines two or more visualization objects. The merge collects points, rectangles, lines, circles and text, but omits arrows.

Include arrows in that same merge. The change leaves stage assignment, active-stage delegation and the single-visualization path unchanged. Four regression/control tests check completed stages (arrow geometry/style and existing point step metadata), initial + stage + final graphics, and the active/single-stage paths.

Verification

At head 144e572c04db638d840cee425a74926dc88eb267, all three upstream checks passed:

The initial test version assumed newer graphics-debug arrow label/step fields. CI correctly caught that mismatch with the declared graphics-debug@0.0.76; the follow-up test commit now uses only supported arrow geometry/style fields and does not alter dependency versions. No test was removed.

An isolated local Node 22.16.0 source-level harness also reproduced the missing-array bug and verified the one-line fix. Local solver source copies were checked against their Git blob SHA values. This local harness used the upstream setStepOfAllObjects helper rather than installing the complete dependency, so the actual dependency-resolved Bun/type/format evidence is the CI above. No production build or browser-rendering check is claimed.

Base: a72b99f60680ffbe56a4c72e113ca52c9469921e. Prepared with ChatGPT assistance and the account owner's authorization. No manual human testing is claimed.

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

@ugin-man is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant