Preserve arrows when combining pipeline visualizations - #35
Open
ugin-man wants to merge 3 commits into
Open
Conversation
|
@ugin-man is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BasePipelineSolver.visualize()preserves arrows when returning one stage directly, but drops them as soon as it combines two or more visualization objects. The merge collects points, rectangles, lines, circles and text, but omitsarrows.Include arrows in that same merge. The change leaves stage assignment, active-stage delegation and the single-visualization path unchanged. Four regression/control tests check completed stages (arrow geometry/style and existing point step metadata), initial + stage + final graphics, and the active/single-stage paths.
Verification
At head
144e572c04db638d840cee425a74926dc88eb267, all three upstream checks passed:The initial test version assumed newer graphics-debug arrow
label/stepfields. CI correctly caught that mismatch with the declaredgraphics-debug@0.0.76; the follow-up test commit now uses only supported arrow geometry/style fields and does not alter dependency versions. No test was removed.An isolated local Node 22.16.0 source-level harness also reproduced the missing-array bug and verified the one-line fix. Local solver source copies were checked against their Git blob SHA values. This local harness used the upstream setStepOfAllObjects helper rather than installing the complete dependency, so the actual dependency-resolved Bun/type/format evidence is the CI above. No production build or browser-rendering check is claimed.
Base:
a72b99f60680ffbe56a4c72e113ca52c9469921e. Prepared with ChatGPT assistance and the account owner's authorization. No manual human testing is claimed.