fix: ignore inherited Object keys in pipeline output queries - #41
Open
Flame119052 wants to merge 1 commit into
Open
fix: ignore inherited Object keys in pipeline output queries#41Flame119052 wants to merge 1 commit into
Flame119052 wants to merge 1 commit into
Conversation
hasStageOutput used `in`, so constructor/toString/__proto__ looked like completed stages on an empty pipeline. Use Object.hasOwn so only own outputs count, including a valid zero-valued stage result.
|
@Flame119052 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #40
hasStageOutputusedinonpipelineOutputs = {}, so inherited names likeconstructor,toString, and__proto__looked like completed stages.getStageOutputdid an unrestricted lookup and returned those values.Use
Object.hasOwnso only own output entries count. A real completed stage that returns0still reports as present.Verification
bun test tests/pipeline-output-lookup.test.ts tests/BasePipelineSolver.test.tsbunx tsc --noEmit