fix: spread getConstructorParams tuples in download templates - #42
Open
Flame119052 wants to merge 1 commit into
Open
fix: spread getConstructorParams tuples in download templates#42Flame119052 wants to merge 1 commit into
Flame119052 wants to merge 1 commit into
Conversation
Generic page.tsx and test.ts downloads passed the whole
getConstructorParams() result as one argument, so a tuple like
[{ limit: 7 }, 3] reconstructed as [[{ limit: 7 }, 3]]. Spread arrays
and wrap legacy plain-object returns as a single argument.
|
@Flame119052 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #39
Generic
page.tsxandtest.tsdownloads passed the entiregetConstructorParams()result as a single constructor argument. A tuplelike
[{ limit: 7 }, 3]reconstructed as[[{ limit: 7 }, 3]], so thesecond argument was undefined.
Generated construction now spreads arrays and wraps a legacy plain-object
return as one argument. The SchematicTracePipelineSolver-specific page
template is unchanged.
Verification
bun test tests/format-solver-constructor-call.test.tsbunx tsc --noEmit