fix: record tryFinalAcceptance exceptions like _step failures - #45
Open
Flame119052 wants to merge 1 commit into
Open
fix: record tryFinalAcceptance exceptions like _step failures#45Flame119052 wants to merge 1 commit into
Flame119052 wants to merge 1 commit into
Conversation
Exceptions from the final-acceptance hook escaped step() without setting failed/error, so a later step() retried the hook and counted past MAX_ITERATIONS.
|
@Flame119052 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tryFinalAcceptance()runs outside the_step()try/catch. A thrown error escapedstep()without settingfailedorerror, so a laterstep()retried the hook and incrementediterationspastMAX_ITERATIONS.tryFinalAcceptancenow uses the same catch-and-record policy as_step(). Successful acceptance and normal exhaustion are unchanged.Fixes #44
Test
tests/BaseSolver.test.tscovers a throwing acceptance hook (no retry) and a hook that still accepts a passable solution.