[pull] master from php:master - #1212
Merged
Merged
Conversation
FUZZER_BUILD links $(PHP_BINARY_OBJS), including main/internal_functions_cli.lo, but the php-fuzz-* rules list $(PHP_SAPI_OBJS), including main/internal_functions.lo, as prerequisites. Building a fuzzer target in isolation from a clean tree therefore fails because internal_functions_cli.lo has not been built. Use $(PHP_BINARY_OBJS) for these prerequisites to match the objects linked by FUZZER_BUILD. This aligns the fuzzer build rules with the CLI, CGI, phpdbg, and litespeed fragments. Assisted-By: Claude Opus 5 Closes #23394
* PHP-8.4: sapi/fuzzer: depend on PHP_BINARY_OBJS instead of PHP_SAPI_OBJS (#23394)
* PHP-8.5: sapi/fuzzer: depend on PHP_BINARY_OBJS instead of PHP_SAPI_OBJS (#23394)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )