Skip to content

fix sort - #1706

Open
jony89 wants to merge 2 commits into
twitter:masterfrom
jony89:master
Open

jony89 wants to merge 2 commits into
twitter:masterfrom
jony89:master

Conversation

@jony89

@jony89 jony89 commented Feb 15, 2018

Copy link
Copy Markdown

since the logic depeneds on the values being sorted correctly (arrayA[ai] < arrayB[bi]) and .sort is not stable and even gives a wrong result according to decimal computation( [14,2].sort() = [14,2], so we must at least give the compareFunction for simple cases

jony89 added 2 commits February 16, 2018 00:44
since the logic depeneds on the values being sorted correctly (`arrayA[ai] < arrayB[bi]`) and .sort is not stable and even gives a wrong result according to decimal computation( [14,2].sort() = [14,2], so we must at least give the `compareFunction` for simple cases
@CLAassistant

CLAassistant commented Jul 29, 2019

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


jony89 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants