feat: make acceleration run comparison useful and fix gray curves - #208
Merged
Conversation
The registry's charts colored every dataset via SignalPaletteService, which keys colors off a loaded file's signal list. The registry is meant to work with no file loaded, so every lookup hit the service's #888888 default and drew every run the same gray. Registry charts now use their own fixed, theme-aware palettes. The comparison itself only overlaid speed curves, where a couple of tenths is invisible. It now offers a Time Gap mode (seconds ahead of / behind a reference run, plotted against speed, so where the time was won or lost is readable), a selectable reference run defaulting to the fastest, gear-shift markers on each run's curve, and a stats table with per-run swatches, deltas, average acceleration and a best-run badge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registry's charts colored every dataset via SignalPaletteService, which keys colors off a loaded file's signal list. The registry is meant to work with no file loaded, so every lookup hit the service's #888888 default and drew every run the same gray. Registry charts now use their own fixed, theme-aware palettes.
The comparison itself only overlaid speed curves, where a couple of tenths is invisible. It now offers a Time Gap mode (seconds ahead of / behind a reference run, plotted against speed, so where the time was won or lost is readable), a selectable reference run defaulting to the fastest, gear-shift markers on each run's curve, and a stats table with per-run swatches, deltas, average acceleration and a best-run badge.