feat: pick WOT filter signals by vehicle tag - #209
Merged
Conversation
The WOT quick-filter always isolated the 175tbi channel set and preselected every signal in the log. On a 2.0gme file that meant filtering ~80 unrelated channels (oil level, fuel level, ...) to then isolate names that ECU never reports. MathDefinition gains autoEnableSignalsByTag, keyed on LoadedFile.tags (seeded from the Drive appProperties a file was loaded with). The WOT formula now maps '175tbi' to the existing list and '2.0gme' to its own, with the 175tbi set kept as the tag-agnostic default so untagged logs behave as before. MathChannelsService resolves the list (resolveAutoEnableSignals), the sources to preselect (resolveBatchSources) and the tag that matched (resolveAutoEnableTag). Signal names are matched case/whitespace- insensitively against the file's own names, like the acceleration extra-curve lookup, since the GME dictionary's newline-split descriptions come through with irregular spacing; an exact-name lookup would silently isolate nothing. A tagged file whose channels are all absent falls back to selecting everything rather than leaving Create disabled with an empty selection. The modal notes which tag drove the preselection under both the "Signals to Filter" and "Signals to Show" fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WOT quick-filter always isolated the 175tbi channel set and preselected every signal in the log. On a 2.0gme file that meant filtering ~80 unrelated channels (oil level, fuel level, ...) to then isolate names that ECU never reports.
MathDefinition gains autoEnableSignalsByTag, keyed on LoadedFile.tags (seeded from the Drive appProperties a file was loaded with). The WOT formula now maps '175tbi' to the existing list and '2.0gme' to its own, with the 175tbi set kept as the tag-agnostic default so untagged logs behave as before.
MathChannelsService resolves the list (resolveAutoEnableSignals), the sources to preselect (resolveBatchSources) and the tag that matched (resolveAutoEnableTag). Signal names are matched case/whitespace- insensitively against the file's own names, like the acceleration extra-curve lookup, since the GME dictionary's newline-split descriptions come through with irregular spacing; an exact-name lookup would silently isolate nothing. A tagged file whose channels are all absent falls back to selecting everything rather than leaving Create disabled with an empty selection.
The modal notes which tag drove the preselection under both the "Signals to Filter" and "Signals to Show" fields.