Feat/acceleration speed brackets - #212
Merged
Merged
Conversation
Acceleration discovery scanned one fixed window (0-100). It now scans a list of speed brackets over the whole log, so a single 0-200 pull yields both the standing 0-100 and the 100-200 roll-on inside it. - AccelerationConfig takes `brackets: SpeedBracket[]` instead of a single startSpeed/targetSpeed; each run carries the bracket it was detected for, and results are grouped by bracket, fastest first within each. Detection itself is unchanged -- a launch is just speed rising through the bracket's start -- so a rolling bracket needs no special casing. - Setup step gets preset chips (0-100, 0-200, 100-200, 80-120) plus editable start/target rows, defaulting to 0-100 + 100-200. Split speed is only recorded for runs that actually crossed it. - Registry gains bracket filter chips and restricts comparison to one bracket at a time, since the overlay and delta chart need a shared speed window. - Top-nav entry renamed 0-100 -> Detect Runs.
The "No 0-100 runs found matching your criteria" alert was painted behind the Acceleration Run Detection dialog that raised it, so the one message explaining why nothing happened was unreadable. .alert-banner and .modal-overlay were both z-index 10000, and analyzer-shell.html declares <app-loading-overlay> before all seven modals, so the tie was broken by DOM order in the modals' favour. Give the overlays an explicit order instead: modals 10000, .loading-overlay 10100, .alert-banner 10200. That also fixes the loading spinner, which at 9999 was hidden behind any modal it was started from - a full-screen blocker that does not block is worse than none. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.