♻️ Refactor Bruner div heat split - #4511
Open
chris-ashe wants to merge 27 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4511 +/- ##
==========================================
- Coverage 49.32% 49.26% -0.07%
==========================================
Files 150 150
Lines 29802 29940 +138
==========================================
+ Hits 14700 14750 +50
- Misses 15102 15190 +88 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
chris-ashe
force-pushed
the
add_bruner_div_heat_split
branch
from
August 14, 2026 12:49
e5d6816 to
95eb74f
Compare
… for clarity and update references
…date references in physics calculations
…pdate references in physics calculations
…date references in plasma calculations; add Brunner's method for divertor power splits calculation
…aust calculations
…rSeparatrixPowerSplits dataclass and update related methods
…ations in Physics class
…ted calculations in Physics class
…ated calculations in Physics class
…ted calculations in Physics class
…ated calculations in Physics class
…output formatting in PlasmaExhaust class
…lations in Physics class
…orSeparatrixPowerSplits
…Data and exhaust modules
…s in Physics class
…modules and update related calculations
… and distances for double null configuration
…plit plotting functions
… inner divertor power splits and update references
chris-ashe
force-pushed
the
add_bruner_div_heat_split
branch
from
August 17, 2026 08:58
95eb74f to
6168a31
Compare
… power decay length and update related variables and tests
chris-ashe
marked this pull request as ready for review
August 17, 2026 09:50
je-cook
reviewed
Aug 17, 2026
|
|
||
| @staticmethod | ||
| def calculate_brunner_divertor_power_splits( | ||
| dr_plasma_outboard_midplane_separatrix_separation: float, |
Collaborator
There was a problem hiding this comment.
this name is far too long to be used in the function (hence the formatting nightmare), fine if you want it for input but please rename it to something more useable inside the function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces significant improvements to the plasma exhaust modeling and visualization in PROCESS. The main changes include the addition of new documentation for plasma exhaust physics, refactoring and renaming of variables related to divertor power splits for clarity and consistency, and the implementation of new plotting functions to visualize separatrix power splits and Brunner model power sharing. These updates enhance both the usability and accuracy of the plasma exhaust modeling, while also improving the documentation and user interface.
Plasma Exhaust Modeling and Documentation:
plasma_exhaust.md) describing separatrix power, divertor protection metrics, and the Brunner model for power splits.Plasma Exhaustto the navigation inmkdocs.ymlfor easier access to the new documentation.Variable Renaming and Data Structure Updates:
f_p_div_lowertof_p_div_lower_separatrixand updated related obsolete variable mappings for clarity and consistency in input, scan, and obsolete variable code.PhysicsDatato include explicit variables for separatrix power splits and target powers (e.g.,f_p_div_inboard_separatrix,p_div_lower_inboard_separatrix_mw, etc.), replacing ambiguous or legacy variable names.Visualization and Plotting Enhancements:
Large tokamak
ST
Codebase Maintenance:
DivertorNumberModelsandPlasmaExhaustwhere required. [1] [2]These changes collectively improve the clarity, maintainability, and scientific accuracy of the plasma exhaust modeling in PROCESS, while also enhancing the user experience through better documentation and visualization.
Checklist
I confirm that I have completed the following checks: