Skip to content

Impurity radiation corrections - #4536

Draft
jonmaddock wants to merge 6 commits into
ukaea:mainfrom
jonmaddock:impurity-radiation-corrections
Draft

Impurity radiation corrections#4536
jonmaddock wants to merge 6 commits into
ukaea:mainfrom
jonmaddock:impurity-radiation-corrections

Conversation

@jonmaddock

@jonmaddock jonmaddock commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Demonstrates the effect of various options for impurity radiation and allows their plotting: this is not intended to be merged in its current form, but as an investigation. Primarily, this demonstrates the importance of separating the reduced core radiation used for the confinement time calculation and the total radiation considered in the plasma power balance, which I currently believe is incorrect.

I hope the following figures highlight a few things and justify the actual changes I want to make. They are all made with the DEMO LAR solution point and varying tungsten fractions. Deliberate horizontal "jitter" is applied to the scatter plots to ensure overlapping points are discernable.

Impurity radiation profiles

impurity rad profiles The current impurity power densities are incorrect because they are multiplied prematurely by the normalised minor radius $\rho$ in preparation for the power integral. This has the effect of the power density dropping to 0 for $\rho = 0$, which is incorrect. The core radiation reduction is also evident outside of the confinement time scaling calculation, where it is only intended to be used. This is corrected. The edge integral is now performed explicitly in the 4th subfigure, which is used later subsequently.

Radiation power

rad power When the core radiation reduction is removed, the core radiation obviously increases, but the edge radiation decreases, due to the "edge = total - core" calculation that is currently used. The edge is optionally now integrated explicitly. The total radiation is the same in all cases.

Separate radiation reduction for confinement time scaling only

pden confinement time Two plasma core radiation power densities are now calculated: one for the confinement time scaling only, the other for the rest of the code. They only differ when the `tau E rad reduction` option is selected (brown), which is the only difference between the plots. This separates the radiation calculated for the rest of the models from the reduced value required by the scaling.

Effect on plasma power balance (PPB)

ppb The effect of these various options on the absolute plasma power balance constraint residual in MW (i.e. MW m^-3, then multiplied by plasma volume ) is shown. The "original" point being slightly above zero is probably due to using a slightly out-of-date solution vector relative to the current Process version. One real difference occurs from using the edge radiation in the PPB (purple) which should always be done in my view: the plasma is not in thermal equilibrium if the edge radiation is ignored. The second, larger, difference is due to the use of the reduced core radiation in the confinement time calculation only, rather than globally (i.e. in the PPB too). This is how this "correction" was originally intended to be used I believe: as a way of effectively changing the confinement time scaling for highly-radiative regimes. It should not affect the actual calculated radiation elsewhere in the models. Around 30 MW for low tungsten values is fairly significant.

I would like to always use the un-reduced total radiation (core and edge) in the plasma power balance calculation, and the reduced core radiation in the confinement time calculation only. This would mean that i_rad_loss and f_p_plasma_core_rad_reduction would only apply to the the confinement time calculation. I'm keen to hear your thoughts.

@jonmaddock
jonmaddock force-pushed the impurity-radiation-corrections branch from 53719e4 to a9b3913 Compare August 16, 2026 09:39
@jonmaddock

Copy link
Copy Markdown
Contributor Author

This appears to independently resolve #3968 (comment).

@mkovari

mkovari commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

this is not intended to be merged in its current form, but as an investigation.

Can you clarify this?

@je-cook

je-cook commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

this is not intended to be merged in its current form, but as an investigation.

Can you clarify this?

I think he means it should probably be split into a few separate PRs after the initial review discussion. Also I guess the switches wont be needed if we agree on the solution

@mkovari

mkovari commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

This appears to independently resolve #3968 (comment).

This link is to the comment on volume-integration. Was that intended?


logger = logging.getLogger(__name__)
include_edge_radiation = False
int_edge_rad = False

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants