Impurity radiation corrections - #4536
Draft
jonmaddock wants to merge 6 commits into
Draft
Conversation
… tauE calculation Leave plasma power balance impurity radiation un-reduced.
jonmaddock
force-pushed
the
impurity-radiation-corrections
branch
from
August 16, 2026 09:39
53719e4 to
a9b3913
Compare
jonmaddock
requested review from
ajpearcey,
chris-ashe,
grmtrkngtn and
mkovari
August 16, 2026 10:23
Contributor
Author
|
This appears to independently resolve #3968 (comment). |
Collaborator
Can you clarify this? |
Collaborator
I think he means it should probably be split into a few separate PRs after the initial review discussion. Also I guess the switches wont be needed if we agree on the solution |
Collaborator
This link is to the comment on volume-integration. Was that intended? |
grmtrkngtn
reviewed
Aug 17, 2026
|
|
||
| logger = logging.getLogger(__name__) | ||
| include_edge_radiation = False | ||
| int_edge_rad = False |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstrates the effect of various options for impurity radiation and allows their plotting: this is not intended to be merged in its current form, but as an investigation. Primarily, this demonstrates the importance of separating the reduced core radiation used for the confinement time calculation and the total radiation considered in the plasma power balance, which I currently believe is incorrect.
I hope the following figures highlight a few things and justify the actual changes I want to make. They are all made with the DEMO LAR solution point and varying tungsten fractions. Deliberate horizontal "jitter" is applied to the scatter plots to ensure overlapping points are discernable.
Impurity radiation profiles
Radiation power
Separate radiation reduction for confinement time scaling only
Effect on plasma power balance (PPB)
I would like to always use the un-reduced total radiation (core and edge) in the plasma power balance calculation, and the reduced core radiation in the confinement time calculation only. This would mean that
i_rad_lossandf_p_plasma_core_rad_reductionwould only apply to the the confinement time calculation. I'm keen to hear your thoughts.