Add Integration Test for Timestamp Behavior - #341
Conversation
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
snps-behrens
left a comment
There was a problem hiding this comment.
Just to clarify. I understood the timestamp behavior implementation in the sync -> sync situation to be that the send time (not the receive time) is used. If it were otherwise, wouldn't NetworkSimulator timestamps be overwritten?
The documentation seems to agree with me (though it is not explicilty stated): https://vectorgrp.github.io/sil-kit-docs/simulation/simulation.html#timestamps-in-messages.
You're right, the logic is (taken from the code): This is: "On reception of a msg with an invalid timestamp (==from async), overwrite it with the local now() of the receiver" So the comment above the test is misleading: |
…ments Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
The timestamp behavior had no integration test. The test covers:
Verify timestamp behavior from the synchronized participant perspective: