Can't clone a repo

[igajsin]

When I try to do 'magithub-clone' it fails with the error: let: Wrong number of arguments: (0 . 1), 2 after I answer 'yes' on the question 'Clone a-repo to a-location: yes, no, or C-u*'

version of my emacs is GNU Emacs 26.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.7)
magithub is installed from the 20190512.2316 MELPA package

Backtrace

Debugger entered--Lisp error: (wrong-number-of-arguments (0 . 1) 2)
  magit-clone("git@github.com:company/repository.git" "/home/user/src/github/company/repository/")
  (let ((default-directory dir) (magit-clone-set-remote\.pushDefault t)) (mkdir dir t) (magit-clone (magithub-repo--clone-url repo) dir) (advice--add-function :after (let* ((v magit-this-process)) (cons (function (lambda nil (process-sentinel v))) (function (lambda (gv--val) (set-process-sentinel v gv--val))))) (function (lambda (process _event) (if (process-live-p process) nil (if set-upstream (progn (let ... ... ... ...)))))) nil))
  (condition-case _ (let ((default-directory dir) (magit-clone-set-remote\.pushDefault t)) (mkdir dir t) (magit-clone (magithub-repo--clone-url repo) dir) (advice--add-function :after (let* ((v magit-this-process)) (cons (function (lambda nil (process-sentinel v))) (function (lambda (gv--val) (set-process-sentinel v gv--val))))) (function (lambda (process _event) (if (process-live-p process) nil (if set-upstream (progn ...))))) nil)))
  (let (set-upstream set-proxy) (setq set-upstream (and \.fork (magithub-confirm-no-error (quote clone-fork-set-upstream-to-parent) \.parent\.full_name)) set-proxy (and set-upstream (magithub-confirm-no-error (quote clone-fork-set-proxy-to-upstream)))) (condition-case _ (let ((default-directory dir) (magit-clone-set-remote\.pushDefault t)) (mkdir dir t) (magit-clone (magithub-repo--clone-url repo) dir) (advice--add-function :after (let* ((v magit-this-process)) (cons (function (lambda nil ...)) (function (lambda ... ...)))) (function (lambda (process _event) (if (process-live-p process) nil (if set-upstream ...)))) nil))))
  (progn (let (set-upstream set-proxy) (setq set-upstream (and \.fork (magithub-confirm-no-error (quote clone-fork-set-upstream-to-parent) \.parent\.full_name)) set-proxy (and set-upstream (magithub-confirm-no-error (quote clone-fork-set-proxy-to-upstream)))) (condition-case _ (let ((default-directory dir) (magit-clone-set-remote\.pushDefault t)) (mkdir dir t) (magit-clone (magithub-repo--clone-url repo) dir) (advice--add-function :after (let* ((v magit-this-process)) (cons (function ...) (function ...))) (function (lambda (process _event) (if ... nil ...))) nil)))))
  (if (magithub-confirm-no-error (quote clone) \.full_name dir) (progn (let (set-upstream set-proxy) (setq set-upstream (and \.fork (magithub-confirm-no-error (quote clone-fork-set-upstream-to-parent) \.parent\.full_name)) set-proxy (and set-upstream (magithub-confirm-no-error (quote clone-fork-set-proxy-to-upstream)))) (condition-case _ (let ((default-directory dir) (magit-clone-set-remote\.pushDefault t)) (mkdir dir t) (magit-clone (magithub-repo--clone-url repo) dir) (advice--add-function :after (let* (...) (cons ... ...)) (function (lambda ... ...)) nil))))))
  (let ((\.full_name (cdr (assq (quote full_name) alist))) (\.fork (cdr (assq (quote fork) alist))) (\.parent\.full_name (cdr (assq (quote full_name) (cdr (assq (quote parent) alist))))) (\.parent (cdr (assq (quote parent) alist)))) (if (magithub-confirm-no-error (quote clone) \.full_name dir) (progn (let (set-upstream set-proxy) (setq set-upstream (and \.fork (magithub-confirm-no-error (quote clone-fork-set-upstream-to-parent) \.parent\.full_name)) set-proxy (and set-upstream (magithub-confirm-no-error (quote clone-fork-set-proxy-to-upstream)))) (condition-case _ (let ((default-directory dir) (magit-clone-set-remote\.pushDefault t)) (mkdir dir t) (magit-clone (magithub-repo--clone-url repo) dir) (advice--add-function :after (let* ... ...) (function ...) nil)))))))
  (let ((alist repo)) (let ((\.full_name (cdr (assq (quote full_name) alist))) (\.fork (cdr (assq (quote fork) alist))) (\.parent\.full_name (cdr (assq (quote full_name) (cdr (assq ... alist))))) (\.parent (cdr (assq (quote parent) alist)))) (if (magithub-confirm-no-error (quote clone) \.full_name dir) (progn (let (set-upstream set-proxy) (setq set-upstream (and \.fork (magithub-confirm-no-error ... \.parent\.full_name)) set-proxy (and set-upstream (magithub-confirm-no-error ...))) (condition-case _ (let (... ...) (mkdir dir t) (magit-clone ... dir) (advice--add-function :after ... ... nil))))))))
  magithub-clone(((id . 171454288) (node_id . "MDEwOlJlcG9zaXRvcnkxNzE0NTQyODg=") (name . "repository") (full_name . "company/repository") (private . t) (owner (login . "company") (id . 5164647) (node_id . "MDEyOk9yZ2FuaXphdGlvbjUxNjQ2NDc=") (avatar_url . "https://avatars3.githubusercontent.com/u/5164647?v=4") (gravatar_id . "") (url . "https://api.github.com/users/company") (html_url . "https://github.com/company") (followers_url . "https://api.github.com/users/company/followers") (following_url . "https://api.github.com/users/company/following{/other_user}") (gists_url . "https://api.github.com/users/company/gists{/gist_id}") (starred_url . "https://api.github.com/users/company/starred{/owner}{/repo}") (subscriptions_url . "https://api.github.com/users/company/subscriptions") (organizations_url . "https://api.github.com/users/company/orgs") (repos_url . "https://api.github.com/users/company/repos") (events_url . "https://api.github.com/users/company/events{/privacy}") (received_events_url . "https://api.github.com/users/company/received_events") (type . "Organization") (site_admin)) (html_url . "https://github.com/company/repository") (description . "Process Intelligence Infrastructure Automation") (fork) (url . "https://api.github.com/repos/company/repository") (forks_url . "https://api.github.com/repos/company/repository/forks") (keys_url . "https://api.github.com/repos/company/repository/keys{/key_id}") (collaborators_url . "https://api.github.com/repos/company/repository/collaborators{/collaborator}") (teams_url . "https://api.github.com/repos/company/repository/teams") (hooks_url . "https://api.github.com/repos/company/repository/hooks") (issue_events_url . "https://api.github.com/repos/company/repository/issues/events{/number}") (events_url . "https://api.github.com/repos/company/repository/events") (assignees_url . "https://api.github.com/repos/company/repository/assignees{/user}") (branches_url . "https://api.github.com/repos/company/repository/branches{/branch}") (tags_url . "https://api.github.com/repos/company/repository/tags") (blobs_url . "https://api.github.com/repos/company/repository/git/blobs{/sha}") (git_tags_url . "https://api.github.com/repos/company/repository/git/tags{/sha}") (git_refs_url . "https://api.github.com/repos/company/repository/git/refs{/sha}") (trees_url . "https://api.github.com/repos/company/repository/git/trees{/sha}") (statuses_url . "https://api.github.com/repos/company/repository/statuses/{sha}") (languages_url . "https://api.github.com/repos/company/repository/languages") (stargazers_url . "https://api.github.com/repos/company/repository/stargazers") (contributors_url . "https://api.github.com/repos/company/repository/contributors") (subscribers_url . "https://api.github.com/repos/company/repository/subscribers") (subscription_url . "https://api.github.com/repos/company/repository/subscription") (commits_url . "https://api.github.com/repos/company/repository/commits{/sha}") (git_commits_url . "https://api.github.com/repos/company/repository/git/commits{/sha}") (comments_url . "https://api.github.com/repos/company/repository/comments{/number}") (issue_comment_url . "https://api.github.com/repos/company/repository/issues/comments{/number}") (contents_url . "https://api.github.com/repos/company/repository/contents/{+path}") (compare_url . "https://api.github.com/repos/company/repository/compare/{base}...{head}") (merges_url . "https://api.github.com/repos/company/repository/merges") (archive_url . "https://api.github.com/repos/company/repository/{archive_format}{/ref}") (downloads_url . "https://api.github.com/repos/company/repository/downloads") (issues_url . "https://api.github.com/repos/company/repository/issues{/number}") (pulls_url . "https://api.github.com/repos/company/repository/pulls{/number}") (milestones_url . "https://api.github.com/repos/company/repository/milestones{/number}") (notifications_url . "https://api.github.com/repos/company/repository/notifications{?since,all,participating}") (labels_url . "https://api.github.com/repos/company/repository/labels{/name}") (releases_url . "https://api.github.com/repos/company/repository/releases{/id}") (deployments_url . "https://api.github.com/repos/company/repository/deployments") (created_at . "2019-02-19T10:32:23Z") (updated_at . "2019-07-26T12:03:37Z") (pushed_at . "2019-07-26T12:03:39Z") (git_url . "git://github.com/company/repository.git") ...) "/home/user/src/github/company/repository/")
  funcall-interactively(magithub-clone ((id . 171454288) (node_id . "MDEwOlJlcG9zaXRvcnkxNzE0NTQyODg=") (name . "repository") (full_name . "company/repository") (private . t) (owner (login . "company") (id . 5164647) (node_id . "MDEyOk9yZ2FuaXphdGlvbjUxNjQ2NDc=") (avatar_url . "https://avatars3.githubusercontent.com/u/5164647?v=4") (gravatar_id . "") (url . "https://api.github.com/users/company") (html_url . "https://github.com/company") (followers_url . "https://api.github.com/users/company/followers") (following_url . "https://api.github.com/users/company/following{/other_user}") (gists_url . "https://api.github.com/users/company/gists{/gist_id}") (starred_url . "https://api.github.com/users/company/starred{/owner}{/repo}") (subscriptions_url . "https://api.github.com/users/company/subscriptions") (organizations_url . "https://api.github.com/users/company/orgs") (repos_url . "https://api.github.com/users/company/repos") (events_url . "https://api.github.com/users/company/events{/privacy}") (received_events_url . "https://api.github.com/users/company/received_events") (type . "Organization") (site_admin)) (html_url . "https://github.com/company/repository") (description . "Process Intelligence Infrastructure Automation") (fork) (url . "https://api.github.com/repos/company/repository") (forks_url . "https://api.github.com/repos/company/repository/forks") (keys_url . "https://api.github.com/repos/company/repository/keys{/key_id}") (collaborators_url . "https://api.github.com/repos/company/repository/collaborators{/collaborator}") (teams_url . "https://api.github.com/repos/company/repository/teams") (hooks_url . "https://api.github.com/repos/company/repository/hooks") (issue_events_url . "https://api.github.com/repos/company/repository/issues/events{/number}") (events_url . "https://api.github.com/repos/company/repository/events") (assignees_url . "https://api.github.com/repos/company/repository/assignees{/user}") (branches_url . "https://api.github.com/repos/company/repository/branches{/branch}") (tags_url . "https://api.github.com/repos/company/repository/tags") (blobs_url . "https://api.github.com/repos/company/repository/git/blobs{/sha}") (git_tags_url . "https://api.github.com/repos/company/repository/git/tags{/sha}") (git_refs_url . "https://api.github.com/repos/company/repository/git/refs{/sha}") (trees_url . "https://api.github.com/repos/company/repository/git/trees{/sha}") (statuses_url . "https://api.github.com/repos/company/repository/statuses/{sha}") (languages_url . "https://api.github.com/repos/company/repository/languages") (stargazers_url . "https://api.github.com/repos/company/repository/stargazers") (contributors_url . "https://api.github.com/repos/company/repository/contributors") (subscribers_url . "https://api.github.com/repos/company/repository/subscribers") (subscription_url . "https://api.github.com/repos/company/repository/subscription") (commits_url . "https://api.github.com/repos/company/repository/commits{/sha}") (git_commits_url . "https://api.github.com/repos/company/repository/git/commits{/sha}") (comments_url . "https://api.github.com/repos/company/repository/comments{/number}") (issue_comment_url . "https://api.github.com/repos/company/repository/issues/comments{/number}") (contents_url . "https://api.github.com/repos/company/repository/contents/{+path}") (compare_url . "https://api.github.com/repos/company/repository/compare/{base}...{head}") (merges_url . "https://api.github.com/repos/company/repository/merges") (archive_url . "https://api.github.com/repos/company/repository/{archive_format}{/ref}") (downloads_url . "https://api.github.com/repos/company/repository/downloads") (issues_url . "https://api.github.com/repos/company/repository/issues{/number}") (pulls_url . "https://api.github.com/repos/company/repository/pulls{/number}") (milestones_url . "https://api.github.com/repos/company/repository/milestones{/number}") (notifications_url . "https://api.github.com/repos/company/repository/notifications{?since,all,participating}") (labels_url . "https://api.github.com/repos/company/repository/labels{/name}") (releases_url . "https://api.github.com/repos/company/repository/releases{/id}") (deployments_url . "https://api.github.com/repos/company/repository/deployments") (created_at . "2019-02-19T10:32:23Z") (updated_at . "2019-07-26T12:03:37Z") (pushed_at . "2019-07-26T12:03:39Z") (git_url . "git://github.com/company/repository.git") ...) "/home/user/src/github/company/repository/")
  call-interactively(magithub-clone record nil)
  command-execute(magithub-clone record)
  #f(compiled-function (cmd) #<bytecode 0x4b47cd>)("magithub-clone")
  ivy-call()
  ivy-read("M-x " [js--tmp-location c-clear-char-property-fun diary-included-files confluence-get-page-at-point -flatten-n slime-repl-set-package -is-infix\? slime-trace-dialog--trace gdb-script-syntax-propertize-function custom-face-menu label-save-customized-colors magit-reflog-commit markdown-xhtml-body-preamble magithub-edit-mode-syntax-table vc-git-make-version-backups-p extend-region-p tramp-gvfs-handle-copy-file ols magithub-edit-submit slime-apropos-symbol js--expression-in-sgml-indent-line sgml-syntax-propertize gdb-frame-locals-buffer makefile-browser-format-macro-line woman-addition matched-string tls-success separator-prop slime-redirect-inferior-output cornsilk 0 post-deadline checkdoc-package-keywords-flag shr-parse-image-data c-mode-var f-directory\? message-kill-actions time-format makefile-insert-gmake-function \' :swank-dependencies slime-inferior-lisp-program-history slime-toggle-trace-fdefinition org-babel-results-keyword request-list sgml-tag-name--cmacro not-at-beginning-of-line f-empty\? woman-use-topic-at-point-default doc-view-pdf/ps->png ...] :predicate #f(compiled-function (sym) #<bytecode 0x4b47a5>) :require-match t :history counsel-M-x-history :action #f(compiled-function (cmd) #<bytecode 0x4b47cd>) :sort t :keymap (keymap (67108908 . counsel--info-lookup-symbol) (67108910 . counsel-find-symbol)) :initial-input nil :caller counsel-M-x)
  counsel-M-x()
  funcall-interactively(counsel-M-x)
  call-interactively(counsel-M-x nil nil)
  command-execute(counsel-M-x)

[vermiculus]

I'd recommend switching to Forge if you can, but this patch should do the trick:

@@ -390,7 +390,7 @@ (defun magithub-clone (repo dir)
             (let ((default-directory dir)
                   (magit-clone-set-remote.pushDefault t))
               (mkdir dir t)
-              (magit-clone (magithub-repo--clone-url repo) dir)
+              (magit-clone-regular (magithub-repo--clone-url repo) dir)
               (add-function
                :after
                (process-sentinel magit-this-process)

I'll try to get this merged into master, but honestly my local state is so borked up from trying to adapt to recent changes upstream that I'm not sure when that'll happen.