Conversation
The kernel-deps generator took the first Version: and Release: lines of each kernel spec and its build_if. A spec that serves several subreleases - SPECS/linux/linux.spec builds kernel 6.1 up to photon_subrelease 90 and 6.12 from 91 - keeps each kernel's Version behind a subrelease conditional and its Release in an included file, so the first Version belonged to the wrong kernel, Release was not found and the generator crashed, stopping make image. The spec is now resolved for the current subrelease first: plain photon_subrelease comparisons are decided and %include'd files are inlined. Without a build_if, the subrelease condition around Version: becomes the build target, as the separate per-subrelease spec stated it. For specs without subrelease conditionals nothing changes: versions, releases and build targets for subreleases 90, 91 and 92 are the same as before, for both the current specs and the single-source kernel specs. Change-Id: Ied11d8260b9ea3d37c4fe322e5c2c5ea880535b3 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JW73JTCUGRcaNTUEQcAMtf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
create-kernel-deps-specs-from-template.pytakes the firstVersion:andRelease:lines and thebuild_ifof each kernel spec. A spec that serves several subreleases keeps each kernel'sVersionbehind a subrelease conditional and itsReleasein an included file. The firstVersionthen belongs to the wrong kernel,Releaseis not found, and the generator crashes, which stopsmake image.Change
The spec is resolved for the current subrelease first: plain
photon_subreleasecomparisons are decided and%included files are inlined. When a spec has nobuild_if, the subrelease condition aroundVersion:becomes the build target, as the separate per-subrelease spec stated it. A missing Version or Release now fails with a clear message.Testing
🤖 Generated with Claude Code